refactor(ui): remove dead rail unarchive - #5190
Open
Phoenix500526 wants to merge 1 commit into
Open
Conversation
Archived tasks are filtered before rail projection. The restore branch was unreachable, so the rail contract no longer exposes it. Closes apache#5189 Generated-by: OpenAI Codex Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
This was referenced Sep 11, 2026
me2seeks
approved these changes
Sep 11, 2026
me2seeks
left a comment
me2seeks
left a comment
Contributor
There was a problem hiding this comment.
PR 5190 Review
结论
APPROVE
删除的 rail unarchive 路径确为死代码：sessionMatchesRail（apps/desktop/src/renderer/features/session-navigation/model/session-nav-filter.ts:31）在投影前过滤掉 isArchived，rail 上的行永远不会 isArchived===true，onUnarchive 分支不可达；全仓 grep 确认 SessionRowActions.onUnarchive 无其他消费者（work-board 的 onUnarchive 是不同接口、使用 desktop 自己的 locales/conversation-copy.ts，未动）。ConversationCopy.sessions.unarchive 的移除也与之配套（无残留引用）。
发现
无
不确定性（不发到 GitHub 的疑虑）
packages/ui/src/conversation-copy.tszh-TW 里既有缺陷showMoreAriaLabel: (count) =>顯示 ${count} 條更多工``（"更多工" 缺"作"字）在 diff 新旧行中原样保留，未被本 PR 引入也未被修；与删除 unarchive 同处一行，顺带修掉会更好，但属 pre-existing。
✅ 对抗性审查（第一性原理 + 奥卡姆剃刀 + 证据核对）通过：未发现真实的 P0–P3 问题。@me2seeks 请把关是否 merge。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unreachable task-rail Unarchive path. Archived sessions are
excluded before rail projection, so
SessionRowActions.onUnarchiveand itsrendering branch could not run in production.
Keep the active restore paths unchanged: Settings > Archived Tasks, the
session controller and IPC boundary, archived projects, and Work Board.
Fixes #5189
Verification
npm exec biome lint -- <9 changed files>— passednpm run format:check— passed (2,075 files)npm --workspace @maka/ui run build— passednpm --workspace @maka/ui run test:dist— passed (430 tests)npm --workspace @maka/desktop run typecheck— passeddoes not change a rendered reachable state.
AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex analyzed reachability, implemented the cleanup,
updated fixtures, ran verification, and drafted this pull request.
Checklist
Does this PR entail a change in behavior?